Issue 8355042: aura: Use the existing notification system.

Issue 8355042: aura: Use the existing notification system. (Closed)

Created:
9 years, 1 month ago by sadrul

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

aura: Use the existing notification system. BUG=98331 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108132

Patch Set 2 : comment #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -41 lines)			Patch
M	chrome/browser/chromeos/cros_stubs_aura.cc	View		1 chunk	+0 lines, -24 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_views.cc	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/notifications/balloon_view_host.cc	View		3 chunks	+15 lines, -14 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		3 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

http://codereview.chromium.org/8355042/diff/1/chrome/browser/notifications/balloon_collection_views.cc File chrome/browser/notifications/balloon_collection_views.cc (right): http://codereview.chromium.org/8355042/diff/1/chrome/browser/notifications/balloon_collection_views.cc#newcode52 chrome/browser/notifications/balloon_collection_views.cc:52: #elif defined(USE_AURA) You will need to do this first, ...

9 years, 1 month ago (2011-11-01 16:18:50 UTC) #2

sadrul

9 years, 1 month ago (2011-11-01 16:21:20 UTC) #3

Ben Goodger (Google)

lgtm http://codereview.chromium.org/8355042/diff/1/chrome/browser/notifications/balloon_collection_views.cc File chrome/browser/notifications/balloon_collection_views.cc (right): http://codereview.chromium.org/8355042/diff/1/chrome/browser/notifications/balloon_collection_views.cc#newcode52 chrome/browser/notifications/balloon_collection_views.cc:52: #elif defined(USE_AURA) OK, can you note that the ...

9 years, 1 month ago (2011-11-01 16:30:14 UTC) #4

sadrul

9 years, 1 month ago (2011-11-01 17:06:22 UTC) #5

Thanks!

http://codereview.chromium.org/8355042/diff/1/chrome/browser/notifications/ba...
File chrome/browser/notifications/balloon_collection_views.cc (right):

http://codereview.chromium.org/8355042/diff/1/chrome/browser/notifications/ba...
chrome/browser/notifications/balloon_collection_views.cc:52: #elif
defined(USE_AURA)
On 2011/11/01 16:30:14, Ben Goodger (Google) wrote:
> OK, can you note that the OS_WIN code is fine for USE_AURA too on windows
then?

Done.

Expand Messages | Collapse Messages