Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 8355035: Refactor elements kind conversion. (Closed)

Created:
9 years, 2 months ago by Yang
Modified:
9 years, 2 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Refactor elements kind conversion. Committed: http://code.google.com/p/v8/source/detail?r=9724

Patch Set 1 #

Patch Set 2 : Ported to all architectures and moved code to codegen*. #

Patch Set 3 : Rebased to bleeding edge. #

Total comments: 1

Patch Set 4 : Updated some comments. #

Patch Set 5 : Bugfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+795 lines, -731 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 2 chunks +4 lines, -246 lines 0 comments Download
M src/arm/codegen-arm.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 1 2 3 4 2 chunks +249 lines, -0 lines 0 comments Download
M src/arm/ic-arm.cc View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 2 5 chunks +9 lines, -14 lines 0 comments Download
M src/code-stubs.cc View 1 2 1 chunk +19 lines, -14 lines 0 comments Download
M src/codegen.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 2 chunks +4 lines, -270 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 2 chunks +258 lines, -0 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 2 3 2 chunks +16 lines, -2 lines 0 comments Download
M src/ic.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 2 chunks +3 lines, -181 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 2 chunks +185 lines, -0 lines 0 comments Download
M src/x64/ic-x64.cc View 1 2 3 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
First draft. Please take a look before I continue with the other platforms.
9 years, 2 months ago (2011-10-20 07:41:54 UTC) #1
danno
This is definitely going in the right direction.
9 years, 2 months ago (2011-10-20 08:52:23 UTC) #2
Yang
Changed all platforms and rebased to include tracing. Please take another look. http://codereview.chromium.org/8355035/diff/3002/src/arm/codegen-arm.h File src/arm/codegen-arm.h ...
9 years, 2 months ago (2011-10-20 11:10:17 UTC) #3
Jakob Kummerow
Now that you've fixed everything we've talked about offline, LGTM :-)
9 years, 2 months ago (2011-10-20 12:19:45 UTC) #4
danno
9 years, 2 months ago (2011-10-20 12:31:33 UTC) #5
LGTM if elements transition tracing still works.

Powered by Google App Engine
This is Rietveld 408576698