Fix an Autofill crash caused by accessing the g_browser_process on the DB thread.

chrome/browser/webdata/web_database_migration_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/file_util.h"
+#include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
 #include "base/stl_util.h"
 #include "base/string16.h"
 #include "base/string_number_conversions.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/autofill/autofill_profile.h"
 #include "chrome/browser/autofill/autofill_type.h"
 #include "chrome/browser/autofill/credit_card.h"
 #include "chrome/browser/webdata/autofill_change.h"
 #include "chrome/browser/webdata/autofill_entry.h"
 #include "chrome/browser/webdata/web_database.h"
+#include "content/browser/browser_thread.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/guid.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "sql/statement.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::Time;
 
 namespace {
 
@@ skipping 90 matching lines @@
 }
 
 }  // anonymous namespace
 
 // The WebDatabaseMigrationTest encapsulates testing of database migrations.
 // Specifically, these tests are intended to exercise any schema changes in
 // the WebDatabase and data migrations that occur in
 // |WebDatabase::MigrateOldVersionsAsNeeded()|.
 class WebDatabaseMigrationTest : public testing::Test {
  public:
-  WebDatabaseMigrationTest() {}
+  // In order to access the application locale -- which the tested functions do
+  // internally -- this test must run on the UI thread.
+  // TODO(isherman): The WebDatabase code should probably verify that it is
+  // running on the DB thread.  Once that verification is added, this code will
+  // need to be updated to create both threads.
+  WebDatabaseMigrationTest()
+      : ui_thread_(BrowserThread::UI, &message_loop_for_ui_) {}
   virtual ~WebDatabaseMigrationTest() {}
 
   virtual void SetUp() {
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
   }
 
  protected:
   // Current tested version number.  When adding a migration in
   // |WebDatabase::MigrateOldVersionsAsNeeded()| and changing the version number
   // |kCurrentVersionNumber| this value should change to reflect the new version
@@ skipping 31 matching lines @@
   // database.
   // Like this:
   //   > .output version_nn.sql
   //   > .dump
   void LoadDatabase(const FilePath::StringType& file);
 
   // Assertion testing for migrating from version 27 and 28.
   void MigrateVersion28Assertions();
 
  private:
+  MessageLoopForUI message_loop_for_ui_;
+  BrowserThread ui_thread_;
   ScopedTempDir temp_dir_;
 
   DISALLOW_COPY_AND_ASSIGN(WebDatabaseMigrationTest);
 };
 
 const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 40;
 
 void WebDatabaseMigrationTest::LoadDatabase(const FilePath::StringType& file) {
   std::string contents;
   ASSERT_TRUE(GetWebDatabaseData(FilePath(file), &contents));
@@ skipping 1366 matching lines @@
         &default_search_provider_id_backup));
     EXPECT_EQ(default_search_provider_id, default_search_provider_id_backup);
 
     std::string default_search_provider_id_backup_signature;
     EXPECT_TRUE(meta_table.GetValue(
         "Default Search Provider ID Backup Signature",
         &default_search_provider_id_backup_signature));
   }
 }