Fix an Autofill crash caused by accessing the g_browser_process on the DB thread.

chrome/browser/autofill/phone_number_i18n.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/phone_number_i18n.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/stringprintf.h"
 #include "base/string_number_conversions.h"
@@ skipping 50 matching lines @@
   country_code->clear();
 
   std::string number_text(UTF16ToUTF8(value));
 
   // Parse phone number based on the locale.
   PhoneNumberUtil* phone_util = PhoneNumberUtil::GetInstance();
 
   // The |locale| should already be sanitized.
   DCHECK_EQ(2U, locale.size());
   if (phone_util->Parse(number_text, locale.c_str(), i18n_number) !=
-          i18n::phonenumbers::PhoneNumberUtil::NO_PARSING_ERROR) {
+      i18n::phonenumbers::PhoneNumberUtil::NO_PARSING_ERROR) {
     return false;
   }
 
   i18n::phonenumbers::PhoneNumberUtil::ValidationResult validation =
       phone_util->IsPossibleNumberWithReason(*i18n_number);
   if (validation != i18n::phonenumbers::PhoneNumberUtil::IS_POSSIBLE)
     return false;
 
   // This verifies that number has a valid area code (that in some cases could
   // be empty) for parsed country code. Also verifies that this is a valid
@@ skipping 135 matching lines @@
                        const string16& number_b,
                        const std::string& country_code) {
   // Sanitize the provided |country_code| before trying to use it for parsing.
   const std::string locale = SanitizeLocaleCode(country_code);
 
   PhoneNumberUtil* phone_util = PhoneNumberUtil::GetInstance();
 
   // Parse phone numbers based on the locale
   PhoneNumber i18n_number1;
   if (phone_util->Parse(UTF16ToUTF8(number_a), locale.c_str(), &i18n_number1) !=
-          i18n::phonenumbers::PhoneNumberUtil::NO_PARSING_ERROR) {
+      i18n::phonenumbers::PhoneNumberUtil::NO_PARSING_ERROR) {
     return false;
   }
 
   PhoneNumber i18n_number2;
   if (phone_util->Parse(UTF16ToUTF8(number_b), locale.c_str(), &i18n_number2) !=
       i18n::phonenumbers::PhoneNumberUtil::NO_PARSING_ERROR) {
     return false;
   }
 
   switch (phone_util->IsNumberMatch(i18n_number1, i18n_number2)) {
     case i18n::phonenumbers::PhoneNumberUtil::INVALID_NUMBER:
     case i18n::phonenumbers::PhoneNumberUtil::NO_MATCH:
       return false;
     case i18n::phonenumbers::PhoneNumberUtil::SHORT_NSN_MATCH:
       return false;
     case i18n::phonenumbers::PhoneNumberUtil::NSN_MATCH:
     case i18n::phonenumbers::PhoneNumberUtil::EXACT_MATCH:
       return true;
     default:
       NOTREACHED();
   }
 
   return false;
 }
 
 PhoneObject::PhoneObject(const string16& number, const std::string& locale)
     : locale_(SanitizeLocaleCode(locale)),
       i18n_number_(NULL) {
+  // TODO(isherman): Autofill profiles should always have a |locale| set, but in
+  // some cases it should be marked as implicit.  Otherwise, phone numbers
+  // might behave differently when they are synced across computers:
+  // [ http://crbug.com/100845 ].  Once the bug is fixed, add a DCHECK here to
+  // verify.
+
   scoped_ptr<PhoneNumber> i18n_number(new PhoneNumber);
   if (ParsePhoneNumberInternal(number, locale_, &country_code_, &city_code_,
                                &number_, i18n_number.get())) {
     // Phone successfully parsed - set |i18n_number_| object, |whole_number_|
     // will be set on the first call to GetWholeNumber().
     i18n_number_.reset(i18n_number.release());
   } else {
     // Parsing failed. Store passed phone "as is" into |whole_number_|.
     whole_number_ = number;
   }
@@ skipping 33 matching lines @@
   number_ = other.number_;
   locale_ = other.locale_;
   if (other.i18n_number_.get())
     i18n_number_.reset(new PhoneNumber(*other.i18n_number_));
 
   return *this;
 }
 
 }  // namespace autofill_i18n