Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1959)

Unified Diff: chrome/browser/ui/webui/tracing_ui.cc

Issue 8355024: Internalize JSON chunk management to trace_event.h API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/tracing_ui.cc
diff --git a/chrome/browser/ui/webui/tracing_ui.cc b/chrome/browser/ui/webui/tracing_ui.cc
index f13f15e3780c5aec12cf6afc5df99857b87335b6..efd15625114410e5086ba2c3932b782072c08a88 100644
--- a/chrome/browser/ui/webui/tracing_ui.cc
+++ b/chrome/browser/ui/webui/tracing_ui.cc
@@ -63,7 +63,7 @@ class TracingMessageHandler
// TraceSubscriber implementation.
virtual void OnEndTracingComplete();
- virtual void OnTraceDataCollected(const std::string& json_events);
+ virtual void OnTraceDataCollected(const std::string& trace_fragment);
virtual void OnTraceBufferPercentFullReply(float percent_full);
// Messages.
@@ -419,13 +419,20 @@ void TracingMessageHandler::OnEndTracingComplete() {
}
void TracingMessageHandler::OnTraceDataCollected(
- const std::string& json_events) {
+ const std::string& trace_fragment) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- std::string javascript = "tracingController.onTraceDataCollected("
- + json_events + ");";
+
+ base::debug::TraceResultBuffer::SimpleOutput output;
+ base::debug::TraceResultBuffer trace_buffer;
+ trace_buffer.SetOutputCallback(output.GetCallback());
+ output.Append("tracingController.onTraceDataCollected(");
+ trace_buffer.Start();
+ trace_buffer.AddFragment(trace_fragment);
+ trace_buffer.Finish();
+ output.Append(");");
web_ui_->tab_contents()->render_view_host()->
- ExecuteJavascriptInWebFrame(string16(), UTF8ToUTF16(javascript));
+ ExecuteJavascriptInWebFrame(string16(), UTF8ToUTF16(output.json_output));
}
void TracingMessageHandler::OnTraceBufferPercentFullReply(float percent_full) {

Powered by Google App Engine
This is Rietveld 408576698