Issue 8355007: Get rid of RunShell*() functions in gcl.py to finish the conversion to subprocess2 - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(265)

My Issues | Starred Open | Closed | All

Issue 8355007: Get rid of RunShell*() functions in gcl.py to finish the conversion to subprocess2 (Closed)

Created:
9 years, 2 months ago by M-A Ruel

Modified:
9 years, 2 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Get rid of RunShell*() functions in gcl.py to finish the conversion to subprocess2 R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106358

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -48 lines)			Patch
	M	gcl.py	View		6 chunks	+23 lines, -43 lines	0 comments	Download
	M	tests/gcl_unittest.py	View		3 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8355007/1

9 years, 2 months ago (2011-10-19 19:46:00 UTC) #3

Change committed as 106358

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698