Issue 8354032: Make MessageLoop::QuitClosure call Quit of the current MessageLoop at call time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8354032: Make MessageLoop::QuitClosure call Quit of the current MessageLoop at call time. (Closed)

Created:
9 years, 2 months ago by not at google - send to devlin

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, willchan no longer on Chromium

CC:
chromium-reviews, sadrul, brettw-cc_chromium.org, James Hawkins

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make MessageLoop::QuitClosure call Quit of the current MessageLoop at call time, not the current MessageLoop at the Closure's creation time. This brings the behaviour of QuitClosure in line with QuitTask. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106684

Patch Set 1 #

Patch Set 2 : . #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	base/message_loop.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/8354032/1003

9 years, 2 months ago (2011-10-21 00:10:40 UTC) #3

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

9 years, 2 months ago (2011-10-21 03:44:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/8354032/1003

9 years, 2 months ago (2011-10-21 03:45:25 UTC) #5

Change committed as 106684

Expand Messages | Collapse Messages