Issue 8354028: Use base::IgnoreReturn<bool>( instead of base::IgnoreReturn(base::Callback<bool(void)>(.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8354028: Use base::IgnoreReturn<bool>( instead of base::IgnoreReturn(base::Callback<bool(void)>(. (Closed)

Created:
9 years, 2 months ago by Mike Mammarella

Modified:
9 years, 2 months ago

Reviewers:
wjia(left Chromium), awong

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use base::IgnoreReturn<bool>( instead of base::IgnoreReturn(base::Callback<bool(void)>(. BUG=98919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107003

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+165 lines, -165 lines)			Patch
M	chrome/browser/password_manager/native_backend_gnome_x_unittest.cc	View	20 chunks	+81 lines, -81 lines	0 comments	Download
M	chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc	View	19 chunks	+78 lines, -78 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_x_unittest.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mike Mammarella

On 2011/10/20 01:15:53, Mike Mammarella wrote: s/wija/wjia/

9 years, 2 months ago (2011-10-20 01:18:44 UTC) #2

wjia(left Chromium)

lgtm. Sorry for the delay. I thought I was on cc list.

9 years, 2 months ago (2011-10-24 20:27:16 UTC) #4

Mike Mammarella

9 years, 2 months ago (2011-10-24 20:29:19 UTC) #5

On 2011/10/24 20:27:16, wjia wrote:
> lgtm. Sorry for the delay. I thought I was on cc list.

You were, I was waiting for awong. But either is good. Thanks for pointing out
that this simpler construction works.

Expand Messages | Collapse Messages