Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 8353040: Remove 'enable lazy background pages' from about:flags (Closed)

Created:
9 years, 1 month ago by Tessa MacDuff
Modified:
9 years, 1 month ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews
Visibility:
Public.

Description

Remove 'enable lazy background pages' from about:flags R=aa BUG=100351 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107774

Patch Set 1 #

Total comments: 2

Patch Set 2 : "remove name and description strings" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tessa MacDuff
(not sure if '-r aa' worked)
9 years, 1 month ago (2011-10-27 17:24:22 UTC) #1
Aaron Boodman
http://codereview.chromium.org/8353040/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): http://codereview.chromium.org/8353040/diff/1/chrome/browser/about_flags.cc#oldcode133 chrome/browser/about_flags.cc:133: IDS_FLAGS_LAZY_BACKGROUND_PAGES_DESCRIPTION, Remove the string too?
9 years, 1 month ago (2011-10-27 19:29:50 UTC) #2
Aaron Boodman
LGTM ahead of time
9 years, 1 month ago (2011-10-27 19:29:59 UTC) #3
Tessa MacDuff
http://codereview.chromium.org/8353040/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): http://codereview.chromium.org/8353040/diff/1/chrome/browser/about_flags.cc#oldcode133 chrome/browser/about_flags.cc:133: IDS_FLAGS_LAZY_BACKGROUND_PAGES_DESCRIPTION, On 2011/10/27 19:29:50, Aaron Boodman wrote: > Remove ...
9 years, 1 month ago (2011-10-28 18:36:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tessamac@chromium.org/8353040/4001
9 years, 1 month ago (2011-10-28 18:37:00 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 19:52:15 UTC) #6
Change committed as 107774

Powered by Google App Engine
This is Rietveld 408576698