Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: tests/presubmit_unittest.py

Issue 8353039: Temporarily disable CheckRietveldTryJobExecution() while the Rietveld API is being upgraded (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: typo Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index 0c066d17dbb6ed9a00788119679c0f8c0b288105..8c25038231f91f2388da6ce3adf7ede61ebbeb80 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -2000,48 +2000,6 @@ class CannedChecksUnittest(PresubmitTestsBase):
input_api, presubmit.OutputApi, ['test_module'])
self.assertEquals(len(results), 0)
- def testCheckRietveldTryJobExecutionBad(self):
- change = self.mox.CreateMock(presubmit.SvnChange)
- change.scm = 'svn'
- change.issue = 2
- change.patchset = 5
- input_api = self.MockInputApi(change, True)
- connection = self.mox.CreateMockAnything()
- input_api.urllib2.urlopen('uurl/2/get_build_results/5').AndReturn(
- connection)
- connection.read().AndReturn('foo')
- connection.close()
- self.mox.ReplayAll()
-
- results = presubmit_canned_checks.CheckRietveldTryJobExecution(
- input_api, presubmit.OutputApi, 'uurl', ('mac', 'linux'), 'georges')
- self.assertEquals(len(results), 1)
- self.assertEquals(results[0].__class__,
- presubmit.OutputApi.PresubmitNotifyResult)
-
- def testCheckRietveldTryJobExecutionGood(self):
- change = self.mox.CreateMock(presubmit.SvnChange)
- change.scm = 'svn'
- change.issue = 2
- change.patchset = 5
- input_api = self.MockInputApi(change, True)
- connection = self.mox.CreateMockAnything()
- input_api.urllib2.urlopen('uurl/2/get_build_results/5').AndReturn(
- connection)
- connection.read().AndReturn("""amiga|Foo|blah
-linux|failure|bleh
-mac|success|blew
-""")
- connection.close()
- self.mox.ReplayAll()
-
- results = presubmit_canned_checks.CheckRietveldTryJobExecution(
- input_api, presubmit.OutputApi, 'uurl', ('mac', 'linux', 'amiga'),
- 'georges')
- self.assertEquals(len(results), 1)
- self.assertEquals(results[0].__class__,
- presubmit.OutputApi.PresubmitPromptWarning)
-
def testCheckBuildbotPendingBuildsBad(self):
input_api = self.MockInputApi(None, True)
connection = self.mox.CreateMockAnything()
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698