Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 8353034: Fix for a memory leak in views/controls/native/native_view_host_gtk.cc (Closed)

Created:
9 years, 2 months ago by Timur Iskhodzhanov
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Fix for a memory leak in views/controls/native/native_view_host_gtk.cc Landing a patch for Parag Radke, originally reviewed at http://codereview.chromium.org/8294008/ BUG=96368 TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106696

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
M views/controls/native/native_view_host_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Timur Iskhodzhanov
TBR
9 years, 2 months ago (2011-10-20 12:22:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/8353034/1
9 years, 2 months ago (2011-10-20 12:22:28 UTC) #2
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-20 15:35:15 UTC) #3
Parag Radke
On 2011/10/20 15:35:15, I haz the power (commit-bot) wrote: > The commit queue went berserk ...
9 years, 2 months ago (2011-10-21 09:20:58 UTC) #4
Timur Iskhodzhanov
I think this is just a CQ bug. Commited manually as r106696 On 2011/10/21 09:20:58, ...
9 years, 2 months ago (2011-10-21 09:28:46 UTC) #5
Timur Iskhodzhanov
9 years, 2 months ago (2011-10-21 10:54:32 UTC) #6
I'm sorry I have to revert the views/ and tools/ part of the change as it fails
on the Chromium OS bots
e.g.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/bui...

Powered by Google App Engine
This is Rietveld 408576698