External autofill delegates.

content/renderer/autofill_dispatcher.cc

Index: content/renderer/autofill_dispatcher.cc
diff --git a/content/renderer/autofill_dispatcher.cc b/content/renderer/autofill_dispatcher.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ba2c5714b2a3afa71efbe2e03bb1ca5e977b05c0
--- /dev/null
+++ b/content/renderer/autofill_dispatcher.cc
@@ -0,0 +1,31 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/autofill_dispatcher.h"
+
+#include "content/common/autofill_messages.h"
+#include "content/renderer/render_view_impl.h"
+
+
+AutofillDispatcher::AutofillDispatcher(RenderViewImpl* render_view)
+    : content::RenderViewObserver(render_view) {
+}
+
+AutofillDispatcher::~AutofillDispatcher() {}
+
+bool AutofillDispatcher::OnMessageReceived(const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(AutofillDispatcher, message)
+    IPC_MESSAGE_HANDLER(AutofillMsg_SelectAutofillSuggestionAtIndex,
+                        OnSelectAutofillSuggestionAtIndex)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}
+
+void AutofillDispatcher::OnSelectAutofillSuggestionAtIndex(int listIndex) {
+  NOTIMPLEMENTED();
+  // TODO(jrg): enable once changes land in WebKit
+  // render_view()->webview()->selectAutofillSuggestionAtIndex(listIndex);

[Ilya Sherman, 2011/10/26 11:09:58]

What will |selectAutofillSuggestionAtIndex| do?  I would prefer not to add code
to WebKit to support further Autofill functionality unless we really have to. 
The task Chris Sharp is working on right now is to move all of the Autofill
functionality out of WebKit entirely ;)

[John Grabowski, 2011/10/27 03:05:59]

Briefly, at this time WebKit owns the list of suggestions.
Step one is to move display of these suggestions out of WebKit.
(This CL is the Chrome side of that work).
Step two is to move knowledge of the suggestion list out of WebKit as well.
I am working with Chris on the WebKit side; what I currently have is only part
way there.

WebKit and Chrome will still need to communicate.  Although Chrome already knows
the bounding box of the current text input field (which would set the position
of the autofill window on-screen), I don't think Chrome has a "fill input field
with text X" mechanism.  Thus, "out of WebKit entirely" is a bit too strong I
think.

[Ilya Sherman, 2011/10/27 11:01:55]

Hmm, ok.  I think it might be easier to avoid adding new Autofill methods to
WebKit at all; but as long as they are merely transitional, I'm ok with it. 
When you do add the method to WebKit, please mark it clearly as a transitional
API.
Sure, the Chrome renderer will still need to talk to WebKit in order to fill the
form -- that's currently handled in chrome/renderer/autofill, and I don't expect
it to go away.  I just meant that WebKit should not have any particular
knowledge of Autofill as a feature, much like content/ should not.

+}