External autofill delegates.

chrome/browser/autocomplete_history_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "base/string16.h"
 #include "base/task.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete_history_manager.h"
+#include "chrome/browser/autofill/autofill_external_delegate.h"
 #include "chrome/browser/webdata/web_data_service.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/browser/tab_contents/test_tab_contents.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/glue/form_data.h"
 
 using testing::_;
@@ skipping 102 matching lines @@
   webkit_glue::FormField search_field;
   search_field.label = ASCIIToUTF16("Search");
   search_field.name = ASCIIToUTF16("search");
   search_field.value = ASCIIToUTF16("my favorite query");
   search_field.form_control_type = ASCIIToUTF16("search");
   form.fields.push_back(search_field);
 
   EXPECT_CALL(*(web_data_service_.get()), AddFormFields(_)).Times(1);
   autocomplete_manager_->OnFormSubmitted(form);
 }
+
+namespace {
+
+class MockAutofillExternalDelegate : public AutofillExternalDelegate {
+ public:
+  MockAutofillExternalDelegate() {}
+  virtual ~MockAutofillExternalDelegate() {}
+
+  virtual void OnQuery(int query_id,
+                       const webkit_glue::FormData& form,
+                       const webkit_glue::FormField& field) {}
+  MOCK_METHOD5(OnSuggestionsReturned, void(

[dhollowa, 2011/10/26 16:14:22]

nit: indent seems off here.  What about pulling void( down a line?

+                   int query_id,
+                   const std::vector<string16>& autofill_values,
+                   const std::vector<string16>& autofill_labels,
+                   const std::vector<string16>& autofill_icons,
+                   const std::vector<int>& autofill_unique_ids));
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MockAutofillExternalDelegate);
+};
+
+class AutocompleteHistoryManagerStubSend : public AutocompleteHistoryManager {
+ public:
+  explicit AutocompleteHistoryManagerStubSend(TabContents* tab_contents,
+                                              Profile* profile,
+                                              WebDataService* wds)
+      : AutocompleteHistoryManager(tab_contents, profile, wds) {}
+
+  virtual bool Send(IPC::Message* message) { return true; }  // intentional nop
+};
+
+}  // namespace
+
+// Make sure our external delegate is called at the right time.
+TEST_F(AutocompleteHistoryManagerTest, ExternalDelegate) {
+  // Local version with a stubbed out Send()
+  scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager(
+      new AutocompleteHistoryManagerStubSend(contents(),
+                                             &profile_, web_data_service_));

[Ilya Sherman, 2011/10/26 11:09:58]

nit: Can this be stack-allocated, rather than heap-allocated and wrapped in a
scoped_ptr?

+
+  MockAutofillExternalDelegate external_delegate;
+  EXPECT_CALL(external_delegate, OnSuggestionsReturned(_, _,  _,  _,  _));
+  autocomplete_history_manager->SetExternalDelegate(&external_delegate);
+
+  // Should trigger a call to OnSuggestionsReturned, verified by the mock.
+  autocomplete_history_manager->SendSuggestions(NULL);
+}
+