[web-ui settings] Fixes and improvements for settings page searching.

chrome/browser/resources/options/options_page.js

Index: chrome/browser/resources/options/options_page.js
===================================================================
--- chrome/browser/resources/options/options_page.js	(revision 105946)
+++ chrome/browser/resources/options/options_page.js	(working copy)
@@ -124,7 +124,8 @@
       var page = this.registeredPages[name];
       if (!page.parentPage && isRootPageLocked)
         continue;
-      prevVisible = page.visible;
+      if (name == pageName)
+        prevVisible = page.visible;

[Finnur, 2011/10/20 10:00:59]

For this change I don't have enough context to judge. Hoping other reviewer has
it. Same problem with search_page.js.

[csilv, 2011/10/20 17:49:13]

This was the bug that was causing searches to fail if the last page was
selected.  It should only be setting prevVisible based on the target page.  Let
me see if I can make the code more readable by adjusting the variable name
and/or adding a comment.

       page.visible = name == pageName ||
           (!document.documentElement.classList.contains('hide-menu') &&
            page.isAncestorOfPage(targetPage));