Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/resources/options/options_page.js

Issue 8353022: [web-ui settings] Fixes and improvements for settings page searching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/options_page.js
===================================================================
--- chrome/browser/resources/options/options_page.js (revision 105946)
+++ chrome/browser/resources/options/options_page.js (working copy)
@@ -124,7 +124,8 @@
var page = this.registeredPages[name];
if (!page.parentPage && isRootPageLocked)
continue;
- prevVisible = page.visible;
+ if (name == pageName)
+ prevVisible = page.visible;
Finnur 2011/10/20 10:00:59 For this change I don't have enough context to jud
csilv 2011/10/20 17:49:13 This was the bug that was causing searches to fail
page.visible = name == pageName ||
(!document.documentElement.classList.contains('hide-menu') &&
page.isAncestorOfPage(targetPage));

Powered by Google App Engine
This is Rietveld 408576698