[web-ui settings] Fixes and improvements for settings page searching.

chrome/browser/resources/options/options_page.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /////////////////////////////////////////////////////////////////////////////
   // OptionsPage class:
 
   /**
    * Base class for options page.
@@ skipping 106 matching lines @@
         page.willHidePage();
     }
 
     var prevVisible = false;
 
     // Update visibilities to show only the hierarchy of the target page.
     for (var name in this.registeredPages) {
       var page = this.registeredPages[name];
       if (!page.parentPage && isRootPageLocked)
         continue;
-      prevVisible = page.visible;
+      if (name == pageName)
+        prevVisible = page.visible;

[Finnur, 2011/10/20 10:00:59]

For this change I don't have enough context to judge. Hoping other reviewer has
it. Same problem with search_page.js.

[csilv, 2011/10/20 17:49:13]

This was the bug that was causing searches to fail if the last page was
selected.  It should only be setting prevVisible based on the target page.  Let
me see if I can make the code more readable by adjusting the variable name
and/or adding a comment.

       page.visible = name == pageName ||
           (!document.documentElement.classList.contains('hide-menu') &&
            page.isAncestorOfPage(targetPage));
     }
 
     // Update the history and current location.
     if (updateHistory)
       this.updateHistoryState_();
 
     // Always update the page title.
@@ skipping 920 matching lines @@
     canShowPage: function() {
       return true;
     },
   };
 
   // Export
   return {
     OptionsPage: OptionsPage
   };
 });