Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 8353007: Update name to match define. (Closed)

Created:
9 years, 2 months ago by jonathan.backer
Modified:
9 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Update name to match define. In previous CL, moved VIEW_GPU_IMAGE_TRANSPORT to UI_COMPOSITOR_IMAGE_TRANSPORT at reviewer request. Forgot to move views_gpu_image_transport to ui_compositor_image_transport. R=ben@chromium.org BUG=none TEST=none (CL is a no-op) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M build/common.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jonathan.backer
Ooops.
9 years, 2 months ago (2011-10-19 13:42:07 UTC) #1
Ben Goodger (Google)
9 years, 2 months ago (2011-10-19 14:17:33 UTC) #2
LGTM

On Wed, Oct 19, 2011 at 6:42 AM, <backer@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> Ooops.
>
> Description:
> Update name to match define.
>
> In previous CL, moved VIEW_GPU_IMAGE_TRANSPORT to
> UI_COMPOSITOR_IMAGE_TRANSPORT
> at reviewer request. Forgot to move views_gpu_image_transport to
> ui_compositor_image_transport.
>
> R=ben@chromium.org
> BUG=none
> TEST=none (CL is a no-op)
>
>
> Please review this at
http://codereview.chromium.**org/8353007/<http://codereview.chromium.org/8353...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M build/common.gypi
>  M chrome/chrome_browser.gypi
>  M content/content_common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index 3ceabf326cb72ff4179b334642e01c**cec2141dc6..**
> f98356440fdfcca197b5265f45d145**b1384584ef 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -332,9 +332,9 @@
>         # Use GPU accelerated cross process image transport by default
>         # on TOUCH_UI and linux builds with the Aura window manager
>         ['views_compositor==1 and OS=="linux"', {
> -          'views_gpu_image_transport%': 1,
> +          'ui_compositor_image_**transport%': 1,
>         }, {
> -          'views_gpu_image_transport%': 0,
> +          'ui_compositor_image_**transport%': 0,
>         }],
>       ],
>     },
> @@ -348,7 +348,7 @@
>     'toolkit_views%': '<(toolkit_views)',
>     'use_only_pure_views%': '<(use_only_pure_views)',
>     'views_compositor%': '<(views_compositor)',
> -    'views_gpu_image_transport%': '<(views_gpu_image_transport)'**,
> +    'ui_compositor_image_**transport%': '<(views_gpu_image_transport)'**,
>     'use_aura%': '<(use_aura)',
>     'use_openssl%': '<(use_openssl)',
>     'use_nss%': '<(use_nss)',
> @@ -949,7 +949,7 @@
>       ['views_compositor==1', {
>         'defines': ['VIEWS_COMPOSITOR=1'],
>       }],
> -      ['views_gpu_image_transport==**1', {
> +      ['ui_compositor_image_**transport==1', {
>         'defines': ['UI_COMPOSITOR_IMAGE_**TRANSPORT'],
>       }],
>       ['use_aura==1', {
> Index: chrome/chrome_browser.gypi
> diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
> index 17a9b93889f9e4483294b8c86ddd61**cf74e1a063..**
> c8adf4ccdc57f00b89bf99f525fb83**d68f2cbfaa 100644
> --- a/chrome/chrome_browser.gypi
> +++ b/chrome/chrome_browser.gypi
> @@ -4182,13 +4182,13 @@
>             '../ui/aura_shell/aura_shell.**gyp:aura_shell',
>           ],
>         }],
> -        ['views_gpu_image_transport==**0', {
> +        ['ui_compositor_image_**transport==0', {
>           'sources/': [
>             ['exclude', '^browser/renderer_host/**
> accelerated_surface_container_**touch.cc'],
>             ['exclude', '^browser/renderer_host/**
> accelerated_surface_container_**touch.h'],
>           ],
>         }],
> -        ['views_gpu_image_transport==**1', {
> +        ['ui_compositor_image_**transport==1', {
>           'dependencies': [
>             '../ui/gfx/compositor/**compositor.gyp:compositor',
>             '../ui/gfx/gl/gl.gyp:gl',
> Index: content/content_common.gypi
> diff --git a/content/content_common.gypi b/content/content_common.gypi
> index 9f7df73ef730e58ed7daa16d51aca5**8a888516e9..**
> 0184cce4d2e1139c95de003c3943ad**c6b719ab32 100644
> --- a/content/content_common.gypi
> +++ b/content/content_common.gypi
> @@ -288,7 +288,7 @@
>         'common/gpu/x_util.h',
>       ],
>     }],
> -    ['views_gpu_image_transport==**1', {
> +    ['ui_compositor_image_**transport==1', {
>       'sources': [
>         'common/gpu/image_transport_**surface.cc',
>         'common/gpu/image_transport_**surface_linux.cc',
>
>
>

Powered by Google App Engine
This is Rietveld 408576698