Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 8353006: Fix Array.filter to use internal array for result. (Closed)

Created:
9 years, 2 months ago by Michael Starzinger
Modified:
9 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Lasse Reichstein
Visibility:
Public.

Description

Fix Array.filter to use internal array for result. In built-in code we use arrays for internal computations. This makes it possible to affect the built-in code by putting getters or setters on the array prototype chain. Using internal arrays prevents those issues. Related to: http://code.google.com/p/v8/source/detail?r=7040 R=svenpanne@chromium.org TEST=test262/15.4.4.20-9-b-6 Committed: http://code.google.com/p/v8/source/detail?r=9707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M src/array.js View 1 chunk +5 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
PTAL.
9 years, 2 months ago (2011-10-19 13:31:23 UTC) #1
Sven Panne
9 years, 2 months ago (2011-10-19 13:40:10 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698