Issue 8353003: Revert 9673, 9674 and 9675 because of failing webkit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8353003: Revert 9673, 9674 and 9675 because of failing webkit tests. (Closed)

Created:
9 years, 2 months ago by Steven

Modified:
9 years, 2 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Revert 9673, 9674 and 9675 because of failing webkit tests. This reverts commits r9673: "Scope tree serialization and ScopeIterator cleanup." r9674: "Use OS::SNPrintF instead of snprintf." r9675: "Use int instead of size_t, StrLength instead of strlen." Committed: http://code.google.com/p/v8/source/detail?r=9703

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -529 lines)			Patch
M	src/ast.h	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	src/ast-inl.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/contexts.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	src/parser.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/parser.cc	View	23 chunks	+32 lines, -37 lines	0 comments	Download
M	src/runtime.cc	View	8 chunks	+84 lines, -149 lines	0 comments	Download
M	src/scopeinfo.h	View	3 chunks	+10 lines, -5 lines	0 comments	Download
M	src/scopeinfo.cc	View	13 chunks	+20 lines, -47 lines	0 comments	Download
M	src/scopes.h	View	10 chunks	+14 lines, -53 lines	0 comments	Download
M	src/scopes.cc	View	6 chunks	+11 lines, -31 lines	0 comments	Download
M	src/v8globals.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+0 lines, -132 lines	0 comments	Download
M	test/mjsunit/debug-scopes.js	View	4 chunks	+2 lines, -44 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

Does this include a revert of 9674 and 9675 which seems to depend on 9673. ...

9 years, 2 months ago (2011-10-19 11:51:28 UTC) #2

LGTM if it compiles

Expand Messages | Collapse Messages