Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 8352040: Speed up comparison with a constant. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1399 matching lines...) Expand 10 before | Expand all | Expand 10 after
1410 return MarkAsCall(DefineFixed(result, rax), instr); 1410 return MarkAsCall(DefineFixed(result, rax), instr);
1411 } 1411 }
1412 1412
1413 1413
1414 LInstruction* LChunkBuilder::DoCompareIDAndBranch( 1414 LInstruction* LChunkBuilder::DoCompareIDAndBranch(
1415 HCompareIDAndBranch* instr) { 1415 HCompareIDAndBranch* instr) {
1416 Representation r = instr->GetInputRepresentation(); 1416 Representation r = instr->GetInputRepresentation();
1417 if (r.IsInteger32()) { 1417 if (r.IsInteger32()) {
1418 ASSERT(instr->left()->representation().IsInteger32()); 1418 ASSERT(instr->left()->representation().IsInteger32());
1419 ASSERT(instr->right()->representation().IsInteger32()); 1419 ASSERT(instr->right()->representation().IsInteger32());
1420 LOperand* left = UseRegisterAtStart(instr->left()); 1420 LOperand* left = UseRegisterOrConstantAtStart(instr->left());
1421 LOperand* right = UseOrConstantAtStart(instr->right()); 1421 LOperand* right = UseOrConstantAtStart(instr->right());
1422 return new LCmpIDAndBranch(left, right); 1422 return new LCmpIDAndBranch(left, right);
1423 } else { 1423 } else {
1424 ASSERT(r.IsDouble()); 1424 ASSERT(r.IsDouble());
1425 ASSERT(instr->left()->representation().IsDouble()); 1425 ASSERT(instr->left()->representation().IsDouble());
1426 ASSERT(instr->right()->representation().IsDouble()); 1426 ASSERT(instr->right()->representation().IsDouble());
1427 LOperand* left = UseRegisterAtStart(instr->left()); 1427 LOperand* left;
1428 LOperand* right = UseRegisterAtStart(instr->right()); 1428 LOperand* right;
1429 if (instr->left()->IsConstant() && instr->right()->IsConstant()) {
1430 left = UseRegisterOrConstantAtStart(instr->left());
1431 right = UseRegisterOrConstantAtStart(instr->right());
1432 } else {
1433 left = UseRegisterAtStart(instr->left());
1434 right = UseRegisterAtStart(instr->right());
1435 }
1429 return new LCmpIDAndBranch(left, right); 1436 return new LCmpIDAndBranch(left, right);
1430 } 1437 }
1431 } 1438 }
1432 1439
1433 1440
1434 LInstruction* LChunkBuilder::DoCompareObjectEqAndBranch( 1441 LInstruction* LChunkBuilder::DoCompareObjectEqAndBranch(
1435 HCompareObjectEqAndBranch* instr) { 1442 HCompareObjectEqAndBranch* instr) {
1436 LOperand* left = UseRegisterAtStart(instr->left()); 1443 LOperand* left = UseRegisterAtStart(instr->left());
1437 LOperand* right = UseRegisterAtStart(instr->right()); 1444 LOperand* right = UseRegisterAtStart(instr->right());
1438 return new LCmpObjectEqAndBranch(left, right); 1445 return new LCmpObjectEqAndBranch(left, right);
(...skipping 763 matching lines...) Expand 10 before | Expand all | Expand 10 after
2202 LOperand* key = UseOrConstantAtStart(instr->key()); 2209 LOperand* key = UseOrConstantAtStart(instr->key());
2203 LOperand* object = UseOrConstantAtStart(instr->object()); 2210 LOperand* object = UseOrConstantAtStart(instr->object());
2204 LIn* result = new LIn(key, object); 2211 LIn* result = new LIn(key, object);
2205 return MarkAsCall(DefineFixed(result, rax), instr); 2212 return MarkAsCall(DefineFixed(result, rax), instr);
2206 } 2213 }
2207 2214
2208 2215
2209 } } // namespace v8::internal 2216 } } // namespace v8::internal
2210 2217
2211 #endif // V8_TARGET_ARCH_X64 2218 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698