Issue 8352025: Move the definition of disable_nacl% inside a conditional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8352025: Move the definition of disable_nacl% inside a conditional (Closed)

Created:
9 years, 2 months ago by jasonwkim

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move the definition of disable_nacl% inside a conditional and remove the explicit commingling of target_arch=arm and disable_nacl in other parts. The net effect is that NaCl is still disabled on ARM but is more easily enabled. R=bradnelson@google.com BUG=http://code.google.com/p/chromium/issues/detail?id=61695 BUG=http://code.google.com/p/chromium/issues/detail?id=38909 BUG=http://code.google.com/p/nativeclient/issues/detail?id=135 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106527

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	build/common.gypi	View		2 chunks	+7 lines, -4 lines	0 comments	Download
	M	chrome/chrome_exe.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jasonwkim@google.com/8352025/1

9 years, 2 months ago (2011-10-20 16:24:43 UTC) #5

Change committed as 106527

Expand Messages | Collapse Messages