Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: media/filters/ffmpeg_demuxer_unittest.cc

Issue 8352019: Change Read size to a size_t for clarity (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_demuxer.cc ('k') | media/filters/ffmpeg_glue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_demuxer_unittest.cc
===================================================================
--- media/filters/ffmpeg_demuxer_unittest.cc (revision 102015)
+++ media/filters/ffmpeg_demuxer_unittest.cc (working copy)
@@ -497,18 +497,18 @@
.WillOnce(DoAll(SetArgPointee<0>(1024), Return(true)));
// First read.
- EXPECT_EQ(512, demuxer->Read(512, kBuffer));
+ EXPECT_EQ(512u, demuxer->Read(512, kBuffer));
int64 position;
EXPECT_TRUE(demuxer->GetPosition(&position));
EXPECT_EQ(512, position);
// Second read.
- EXPECT_EQ(512, demuxer->Read(512, kBuffer));
+ EXPECT_EQ(512u, demuxer->Read(512, kBuffer));
EXPECT_TRUE(demuxer->GetPosition(&position));
EXPECT_EQ(1024, position);
// Third read will get an end-of-file error, which is represented as zero.
- EXPECT_EQ(0, demuxer->Read(512, kBuffer));
+ EXPECT_EQ(0u, demuxer->Read(512, kBuffer));
// This read complete signal is generated when demuxer is stopped.
EXPECT_CALL(*demuxer, SignalReadCompleted(DataSource::kReadError));
« no previous file with comments | « media/filters/ffmpeg_demuxer.cc ('k') | media/filters/ffmpeg_glue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698