Change Read size to a size_t for clarity

media/filters/in_memory_url_protocol.cc

Index: media/filters/in_memory_url_protocol.cc
===================================================================
--- media/filters/in_memory_url_protocol.cc	(revision 102015)
+++ media/filters/in_memory_url_protocol.cc	(working copy)
@@ -16,11 +16,11 @@
 
 InMemoryUrlProtocol::~InMemoryUrlProtocol() {}
 
-int InMemoryUrlProtocol::Read(int size, uint8* data) {
+int InMemoryUrlProtocol::Read(size_t size, uint8* data) {

[Ami GONE FROM CHROMIUM, 2011/10/19 21:14:58]

ret val

[Cris Neckar, 2011/10/19 22:25:41]

Done.

   if (size < 0)

[Ami GONE FROM CHROMIUM, 2011/10/19 21:14:58]

This check can go away.

[Cris Neckar, 2011/10/19 22:25:41]

Done.

     return -1;
 
-  int available_bytes = static_cast<int>(size_ - position_);
+  size_t available_bytes = size_ - position_;

[Ami GONE FROM CHROMIUM, 2011/10/19 21:14:58]

It'd be nice if size_>=position_ was an invariant of this class.
(seeing the result of a subtraction assigned to an unsigned type gives me the
heebie-jeebies)

[Cris Neckar, 2011/10/19 22:25:41]

When I first saw this I was trying to find a way to make that happen and
couldn't but that isn't to say it couldn't be added later :)

   if (size > available_bytes)
     size = available_bytes;