Change Read size to a size_t for clarity

media/filters/ffmpeg_demuxer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
@@ skipping 333 matching lines @@
     DemuxerStream::Type type) {
   DCHECK_GE(type, 0);
   DCHECK_LT(type, DemuxerStream::NUM_TYPES);
   return streams_[type];
 }
 
 base::TimeDelta FFmpegDemuxer::GetStartTime() const {
   return start_time_;
 }
 
-int FFmpegDemuxer::Read(int size, uint8* data) {
+int FFmpegDemuxer::Read(size_t size, uint8* data) {

[Ami GONE FROM CHROMIUM, 2011/10/19 21:14:58]

ditto ret val

[Cris Neckar, 2011/10/19 22:25:41]

Done.

   DCHECK(data_source_);
 
   // If read has ever failed, return with an error.
   // TODO(hclam): use a more meaningful constant as error.
   if (read_has_failed_)
     return AVERROR(EIO);
 
   // Even though FFmpeg defines AVERROR_EOF, it's not to be used with I/O
   // routines.  Instead return 0 for any read at or past EOF.
   int64 file_size;
@@ skipping 16 matching lines @@
 
     // Returns with a negative number to signal an error to FFmpeg.
     read_has_failed_ = true;
     return AVERROR(EIO);
   }
   read_position_ += last_read_bytes;
 
   if (host())
     host()->SetCurrentReadPosition(read_position_);
 
   return last_read_bytes;

[Ami GONE FROM CHROMIUM, 2011/10/19 21:14:58]

I can't believe with all our clang magic we still allow this silent
truncation...

 }
 
 bool FFmpegDemuxer::GetPosition(int64* position_out) {
   *position_out = read_position_;
   return true;
 }
 
 bool FFmpegDemuxer::SetPosition(int64 position) {
   DCHECK(data_source_);
 
@@ skipping 312 matching lines @@
   read_event_.Wait();
   return last_read_bytes_;
 }
 
 void FFmpegDemuxer::SignalReadCompleted(size_t size) {
   last_read_bytes_ = size;
   read_event_.Signal();
 }
 
 }  // namespace media