Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 8352004: [[DefineOwnProperty]] should always return true/false (or throw an exception), never undefined. (Closed)

Created:
9 years, 2 months ago by Sven Panne
Modified:
9 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

[[DefineOwnProperty]] should always return true/false (or throw an exception), never undefined. Note that this is not an observable behavior, but following the principle of least surprise, we should follow the spec. Additional (extremely tiny) bonus: Some ICs see fewer values => better code. Committed: http://code.google.com/p/v8/source/detail?r=9706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/v8natives.js View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 2 months ago (2011-10-19 13:19:31 UTC) #1
Michael Starzinger
9 years, 2 months ago (2011-10-19 13:20:30 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698