Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 8351066: Expose accessible text attributes for anything with an... (Closed)

Created:
9 years, 1 month ago by dmazzoni
Modified:
9 years, 1 month ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org, aboxhall, David Tseng
Visibility:
Public.

Description

Expose accessible text attributes for anything with an editable text role, not just <input> and <textarea> elements. BUG=none TEST=Try using pure-javascript text editor with VoiceOver on Mac OS X. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108318

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M webkit/glue/webaccessibility.cc View 1 1 chunk +12 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dmazzoni
9 years, 1 month ago (2011-11-02 05:00:02 UTC) #1
tony
LGTM, is it possible to write a test for this?
9 years, 1 month ago (2011-11-02 16:24:33 UTC) #2
dmazzoni
Thanks - we already have WebKit layout tests for accessibility of ARIA text fields, this ...
9 years, 1 month ago (2011-11-02 16:45:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8351066/3001
9 years, 1 month ago (2011-11-02 16:45:31 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-02 18:17:45 UTC) #5
Change committed as 108318

Powered by Google App Engine
This is Rietveld 408576698