PrintPreview: [LINUX] Update the margin values after flipping the paper orientation.

printing/page_setup.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/page_setup.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 
 namespace printing {
 
 PageMargins::PageMargins()
     : header(0),
       footer(0),
       left(0),
       right(0),
       top(0),
       bottom(0) {
 }
 
+PageMargins::PageMargins(const PageMargins& margins, bool rotate_margins) {
+  header = margins.header;
+  footer = margins.footer;
+  if (rotate_margins) {
+    top = margins.right;
+    left = margins.top;
+    bottom = margins.left;
+    right = margins.bottom;
+  } else {
+    top = margins.top;
+    left = margins.left;
+    bottom = margins.bottom;
+    right = margins.right;
+  }
+}
+
 void PageMargins::Clear() {
   header = 0;
   footer = 0;
   left = 0;
   right = 0;
   top = 0;
   bottom = 0;
 }
 
 bool PageMargins::Equals(const PageMargins& rhs) const {
   return header == rhs.header &&
       footer == rhs.footer &&
       left == rhs.left &&
       top == rhs.top &&
       right == rhs.right &&
       bottom == rhs.bottom;
 }
 
-PageSetup::PageSetup() {
+PageSetup::PageSetup() : has_forced_margins_value(false) {
   Clear();
 }
 
 PageSetup::~PageSetup() {}
 
 void PageSetup::Clear() {
   physical_size_.SetSize(0, 0);
   printable_area_.SetRect(0, 0, 0, 0);
   overlay_area_.SetRect(0, 0, 0, 0);
   content_area_.SetRect(0, 0, 0, 0);
@@ skipping 23 matching lines @@
   DCHECK_GE(text_height, 0);
   physical_size_ = physical_size;
   printable_area_ = printable_area;
   text_height_ = text_height;
 
   CalculateSizesWithinRect(printable_area_, text_height_);
 }
 
 void PageSetup::SetRequestedMargins(const PageMargins& requested_margins) {
   requested_margins_ = requested_margins;
+  has_forced_margins_value = false;
   if (printable_area_.width() && printable_area_.height())
     CalculateSizesWithinRect(printable_area_, text_height_);
 }
 
 void PageSetup::ForceRequestedMargins(const PageMargins& requested_margins) {
   requested_margins_ = requested_margins;
+  has_forced_margins_value = true;
   if (physical_size_.width() && physical_size_.height())
     CalculateSizesWithinRect(gfx::Rect(physical_size_), 0);
 }
 
 void PageSetup::FlipOrientation() {
   if (physical_size_.width() && physical_size_.height()) {
     gfx::Size new_size(physical_size_.height(), physical_size_.width());
     int new_y = physical_size_.width() -
                 (printable_area_.width() + printable_area_.x());
     gfx::Rect new_printable_area(printable_area_.y(),
                                  new_y,
                                  printable_area_.height(),
                                  printable_area_.width());
     Init(new_size, new_printable_area, text_height_);
+    PageMargins new_requested_margins(requested_margins_, true);
+    if (has_forced_margins_value)

[vandebo (ex-Chrome), 2011/11/02 20:26:03]

With the addition of has_forced_margins_value, I think we should abstract this,
i.e. add private UpdateValues() that would be called from Init,
Set/ForceRequestedMargins and would call CalculateSizesWithRect.  This would
make FlipOrientation not need to be aware of forced/non-forced margins.

[kmadhusu, 2011/11/02 23:15:03]

Done.

+      ForceRequestedMargins(new_requested_margins);
+    else
+      SetRequestedMargins(new_requested_margins);
   }
 }
 
 void PageSetup::CalculateSizesWithinRect(const gfx::Rect& bounds,
                                          int text_height) {
   // Calculate the effective margins. The tricky part.
   effective_margins_.header = std::max(requested_margins_.header,
                                        bounds.y());
   effective_margins_.footer = std::max(requested_margins_.footer,
                                        physical_size_.height() -
@@ skipping 32 matching lines @@
                                    physical_size_.width() -
                                        effective_margins_.right -
                                        content_area_.x()));
   content_area_.set_height(std::max(0,
                                     physical_size_.height() -
                                         effective_margins_.bottom -
                                         content_area_.y()));
 }
 
 }  // namespace printing