Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: chrome/browser/download/download_manager_unittest.cc

Issue 8351052: Created a DownloadManager interface, for use in unit tests.. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed typo. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_manager_unittest.cc
diff --git a/chrome/browser/download/download_manager_unittest.cc b/chrome/browser/download/download_manager_unittest.cc
index a85fb3efebcc5a9b6295b7ca1953985fb39b3d10..f8869fb1eb91e2c6ee4434a88309922faefe57b0 100644
--- a/chrome/browser/download/download_manager_unittest.cc
+++ b/chrome/browser/download/download_manager_unittest.cc
@@ -28,7 +28,7 @@
#include "content/browser/download/download_file_manager.h"
#include "content/browser/download/download_id_factory.h"
#include "content/browser/download/download_item.h"
-#include "content/browser/download/download_manager.h"
+#include "content/browser/download/download_manager_impl.h"
#include "content/browser/download/download_request_handle.h"
#include "content/browser/download/download_status_updater.h"
#include "content/browser/download/interrupt_reasons.h"
@@ -57,7 +57,7 @@ class DownloadManagerTest : public testing::Test {
download_manager_delegate_(new ChromeDownloadManagerDelegate(
profile_.get())),
id_factory_(new DownloadIdFactory(kValidIdDomain)),
- download_manager_(new MockDownloadManager(
+ download_manager_(new DownloadManagerImpl(
download_manager_delegate_,
id_factory_,
&download_status_updater_)),
@@ -120,9 +120,7 @@ class DownloadManagerTest : public testing::Test {
// Get the download item with ID |id|.
DownloadItem* GetActiveDownloadItem(int32 id) {
- if (ContainsKey(download_manager_->active_downloads_, id))
- return download_manager_->active_downloads_[id];
- return NULL;
+ return download_manager_->GetActiveDownload(id);
}
protected:
@@ -140,7 +138,7 @@ class DownloadManagerTest : public testing::Test {
DownloadFileManager* file_manager() {
if (!file_manager_) {
file_manager_ = new DownloadFileManager(NULL);
- download_manager_->file_manager_ = file_manager_;
+ download_manager_->SetFileManager(file_manager_);
}
return file_manager_;
}

Powered by Google App Engine
This is Rietveld 408576698