Created a DownloadManager interface, for use in unit tests..

chrome/browser/download/download_manager_unittest.cc

Index: chrome/browser/download/download_manager_unittest.cc
diff --git a/chrome/browser/download/download_manager_unittest.cc b/chrome/browser/download/download_manager_unittest.cc
index a85fb3efebcc5a9b6295b7ca1953985fb39b3d10..20612862230efbf4f3947cb1f56af4e332f2f0be 100644
--- a/chrome/browser/download/download_manager_unittest.cc
+++ b/chrome/browser/download/download_manager_unittest.cc
@@ -57,7 +57,7 @@ class DownloadManagerTest : public testing::Test {
         download_manager_delegate_(new ChromeDownloadManagerDelegate(
             profile_.get())),
         id_factory_(new DownloadIdFactory(kValidIdDomain)),
-        download_manager_(new MockDownloadManager(
+        download_manager_(new DownloadManagerImpl(

[Randy Smith (Not in Mondays), 2011/11/08 22:10:51]

Why this change?

[ahendrickson, 2011/11/09 17:09:02]

A) This is a test for DownloadManager.
B) The old version of MockDownloadManager was derived from DownloadManager, and
just added one empty function.  It did not override any functions, so its
functionality was identical to DownloadManager.
C) The new MockDownloadManager is very different from DownloadManager.

The upshot is that this change preserves the functionality of the test!

[Randy Smith (Not in Mondays), 2011/11/09 19:06:34]

Sounds good.

             download_manager_delegate_,
             id_factory_,
             &download_status_updater_)),
@@ -120,9 +120,7 @@ class DownloadManagerTest : public testing::Test {
 
   // Get the download item with ID |id|.
   DownloadItem* GetActiveDownloadItem(int32 id) {
-    if (ContainsKey(download_manager_->active_downloads_, id))
-      return download_manager_->active_downloads_[id];
-    return NULL;
+    return download_manager_->GetActiveDownload(id);
   }
 
  protected:
@@ -140,7 +138,7 @@ class DownloadManagerTest : public testing::Test {
   DownloadFileManager* file_manager() {
     if (!file_manager_) {
       file_manager_ = new DownloadFileManager(NULL);
-      download_manager_->file_manager_ = file_manager_;
+      download_manager_->SetFileManager(file_manager_);
     }
     return file_manager_;
   }