Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/browser/ui/webui/print_preview_ui.h

Issue 8351048: Print Preview: Making margin selection sticky (part 2/2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing nits Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview_ui.h
diff --git a/chrome/browser/ui/webui/print_preview_ui.h b/chrome/browser/ui/webui/print_preview_ui.h
index f4521c7c65bc795c2e984a90f282364f95bce281..057df827d86d3b136e51d260858b8a4f7edb1a88 100644
--- a/chrome/browser/ui/webui/print_preview_ui.h
+++ b/chrome/browser/ui/webui/print_preview_ui.h
@@ -50,6 +50,10 @@ class PrintPreviewUI : public ChromeWebUI {
string16 initiator_tab_title() { return initiator_tab_title_; }
+ bool source_is_modifiable() { return source_is_modifiable_; }
+
+ void SetSourceIsModifiable(bool source_is_modifiable);
+
// Determines whether to cancel a print preview request based on
// |preview_ui_addr| and |request_id|.
// Can be called from any thread.
@@ -132,10 +136,22 @@ class PrintPreviewUI : public ChromeWebUI {
// when the initiator tab is closed/crashed.
std::string initiator_url_;
+ // Indicates whether the source document can be modified.
+ bool source_is_modifiable_;
+
// Store the initiator tab title, used for populating the print preview tab
// title.
string16 initiator_tab_title_;
+ friend class PrintPreviewHandlerTest;
Lei Zhang 2011/11/15 00:12:05 Sorry to keep bugging you with nits, but this shou
dpapad 2011/11/15 00:55:04 No problem. Done.
+ FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest, StickyMarginsCustom);
+ FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest, StickyMarginsDefault);
+ FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest,
+ StickyMarginsCustomThenDefault);
+ FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest,
+ GetLastUsedMarginSettingsCustom);
+ FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest,
+ GetLastUsedMarginSettingsDefault);
DISALLOW_COPY_AND_ASSIGN(PrintPreviewUI);
};
« no previous file with comments | « chrome/browser/ui/webui/print_preview_handler_unittest.cc ('k') | chrome/browser/ui/webui/print_preview_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698