Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 8351045: Change DemuxerStream::ReadCallback to use ref-counted buffers. (Closed)

Created:
9 years, 1 month ago by scherkus (not reviewing)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Change DemuxerStream::ReadCallback to use ref-counted buffers. Previously callbackees had to remember to store the buffer in a scoped_refptr<>. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108178

Patch Set 1 #

Patch Set 2 : forgot some &s #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M media/base/demuxer_stream.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/mock_reader.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 1 chunk +2 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
scherkus (not reviewing)
9 years, 1 month ago (2011-11-01 19:05:00 UTC) #1
Ami GONE FROM CHROMIUM
LGTM *somebody* is having too much fun! http://codereview.chromium.org/8351045/diff/1001/media/filters/ffmpeg_video_decoder.cc File media/filters/ffmpeg_video_decoder.cc (right): http://codereview.chromium.org/8351045/diff/1001/media/filters/ffmpeg_video_decoder.cc#newcode183 media/filters/ffmpeg_video_decoder.cc:183: void FFmpegVideoDecoder::OnReadCompleteTask( ...
9 years, 1 month ago (2011-11-01 19:30:57 UTC) #2
scherkus (not reviewing)
9 years, 1 month ago (2011-11-01 22:10:25 UTC) #3
Discussed offline -- I can't make the OnReadComplete change because we end up
creating a chain of synchronous calls (i.e., what is supposed to be an async
operation became synchronous and reentrant)

Will leave as is but update TODO -- this should get resolved in
http://codereview.chromium.org/8417019/ anyway

Powered by Google App Engine
This is Rietveld 408576698