Issue 8351042: Gets disable inactive frame rendering to work correctly for aura. This

Issue 8351042: Gets disable inactive frame rendering to work correctly for aura. This (Closed)

Created:
9 years, 1 month ago by sky

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dhollowa, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Gets disable inactive frame rendering to work correctly for aura. This is needed for bubbles. BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108179

Patch Set 2 : Tweaks #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+200 lines, -43 lines)			Patch
M	chrome/browser/ui/views/bubble/bubble.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc	View		6 chunks	+24 lines, -13 lines	0 comments	Download
M	ui/aura/desktop.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View		1 chunk	+59 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_aura.h	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_aura.cc	View	1	4 chunks	+36 lines, -0 lines	2 comments	Download
M	views/widget/native_widget_gtk.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	views/widget/native_widget_gtk.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_private.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	views/widget/native_widget_views.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	views/widget/native_widget_views.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_win.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	views/widget/native_widget_win.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	views/widget/widget.h	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	views/widget/widget.cc	View		3 chunks	+12 lines, -6 lines	0 comments	Download
M	views/window/non_client_view.h	View		3 chunks	+11 lines, -10 lines	0 comments	Download
M	views/window/non_client_view.cc	View		3 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

LGTM http://codereview.chromium.org/8351042/diff/2001/views/widget/native_widget_aura.cc File views/widget/native_widget_aura.cc (right): http://codereview.chromium.org/8351042/diff/2001/views/widget/native_widget_aura.cc#newcode447 views/widget/native_widget_aura.cc:447: window_->layer()->ScheduleDraw(); Is this your other CL leaking through? ...

9 years, 1 month ago (2011-11-01 19:22:00 UTC) #2

sky

9 years, 1 month ago (2011-11-01 19:50:56 UTC) #3

http://codereview.chromium.org/8351042/diff/2001/views/widget/native_widget_a...
File views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/8351042/diff/2001/views/widget/native_widget_a...
views/widget/native_widget_aura.cc:447: window_->layer()->ScheduleDraw();
On 2011/11/01 19:22:00, Ben Goodger (Google) wrote:
> Is this your other CL leaking through? I thought you made this implicit to
> SetOpacity.

Ya, sorry. I'll remove that.

Expand Messages | Collapse Messages