chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm - Issue 8351038: [Mac] Stop listening for NSWindowWillCloseNotification in |-dealloc| to fix a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm

Issue 8351038: [Mac] Stop listening for NSWindowWillCloseNotification in |-dealloc| to fix a crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm b/chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm

index 446d47148d00a6680137f9406c6aeeff3774655f..4e71bd4c89d59b77b07973694f23a7ede6a36da6 100644

--- a/chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm

@@ -22,7 +22,7 @@ class HungRendererControllerTest : public CocoaTest {

HungRendererController* hung_renderer_controller_; // owned by its window

};

-TEST_F(HungRendererControllerTest, FLAKY_TestShowAndClose) {

+TEST_F(HungRendererControllerTest, TestShowAndClose) {

// Doesn't test much functionality-wise, but makes sure we can

// display and tear down a window.

[hung_renderer_controller_ showWindow:nil];

« no previous file with comments | « chrome/browser/ui/cocoa/browser/avatar_button_controller.mm ('k') | no next file » | no next file with comments »