Issue 8351038: [Mac] Stop listening for NSWindowWillCloseNotification in |-dealloc| to fix a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8351038: [Mac] Stop listening for NSWindowWillCloseNotification in |-dealloc| to fix a crash. (Closed)

Created:
9 years, 1 month ago by Robert Sesek

Modified:
9 years, 1 month ago

Reviewers:
sail

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Mac] Stop listening for NSWindowWillCloseNotification in |-dealloc| to fix a crash. BUG=101484 TEST=Open the avatar bubble and hit Cmd+Q. No crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108138

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	chrome/browser/ui/cocoa/browser/avatar_button_controller.mm	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/8351038/1

9 years, 1 month ago (2011-11-01 17:05:34 UTC) #3

Change committed as 108138