Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 8351027: Reduce visibility of methods in AutofillManager and AutofillDownload. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: De-nitting Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index 3fbbc993f9559bb7d221576d8f4d4fcec3714de7..0bc082a4f689c4bc4ef39450e4d6bb576983f1a1 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -208,7 +208,7 @@ AutofillManager::AutofillManager(TabContentsWrapper* tab_contents)
: TabContentsObserver(tab_contents->tab_contents()),
tab_contents_wrapper_(tab_contents),
personal_data_(NULL),
- download_manager_(tab_contents->profile()),
+ download_manager_(tab_contents->profile(), this),
disable_download_manager_requests_(false),
metric_logger_(new AutofillMetrics),
has_logged_autofill_enabled_(false),
@@ -222,11 +222,9 @@ AutofillManager::AutofillManager(TabContentsWrapper* tab_contents)
// |personal_data_| is NULL when using TestTabContents.
personal_data_ = PersonalDataManagerFactory::GetForProfile(
tab_contents->profile()->GetOriginalProfile());
- download_manager_.SetObserver(this);
}
AutofillManager::~AutofillManager() {
- download_manager_.SetObserver(NULL);
}
// static
@@ -618,15 +616,6 @@ void AutofillManager::OnLoadedServerPredictions(
SendAutofillTypePredictions(form_structures_.get());
}
-void AutofillManager::OnUploadedPossibleFieldTypes() {
-}
-
-void AutofillManager::OnServerRequestError(
- const std::string& form_signature,
- AutofillDownloadManager::AutofillRequestType request_type,
- int http_error) {
-}
-
bool AutofillManager::IsAutofillEnabled() const {
Profile* profile = Profile::FromBrowserContext(
const_cast<AutofillManager*>(this)->tab_contents()->browser_context());
@@ -736,7 +725,7 @@ AutofillManager::AutofillManager(TabContentsWrapper* tab_contents,
: TabContentsObserver(tab_contents->tab_contents()),
tab_contents_wrapper_(tab_contents),
personal_data_(personal_data),
- download_manager_(NULL),
+ download_manager_(tab_contents->profile(), this),
disable_download_manager_requests_(true),
metric_logger_(new AutofillMetrics),
has_logged_autofill_enabled_(false),
« no previous file with comments | « chrome/browser/autofill/autofill_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698