Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2565)

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_fullscreen_rpc_server.cc

Issue 8351023: PPAPI NaCl Proxy: optimize PPB_Fullscreen::IsFullscreen. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_fullscreen_rpc_server.cc
===================================================================
--- ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_fullscreen_rpc_server.cc (revision 107024)
+++ ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_fullscreen_rpc_server.cc (working copy)
@@ -13,24 +13,8 @@
using ppapi_proxy::DebugPrintf;
using ppapi_proxy::PPBFullscreenInterface;
-void PpbFullscreenRpcServer::PPB_Fullscreen_IsFullscreen(
- NaClSrpcRpc* rpc,
- NaClSrpcClosure* done,
- // inputs
- PP_Instance instance,
- // outputs
- int32_t* success) {
- NaClSrpcClosureRunner runner(done);
- rpc->result = NACL_SRPC_RESULT_APP_ERROR;
+// IsFullscreen is implemented via an extra flag to the DidChangeView proxy.
- PP_Bool pp_success = PPBFullscreenInterface()->IsFullscreen(instance);
- DebugPrintf("PPB_Fullscreen::IsFullscreen: pp_success=%d\n", pp_success);
-
- *success = (pp_success == PP_TRUE);
- rpc->result = NACL_SRPC_RESULT_OK;
-}
-
-
void PpbFullscreenRpcServer::PPB_Fullscreen_SetFullscreen(
NaClSrpcRpc* rpc,
NaClSrpcClosure* done,

Powered by Google App Engine
This is Rietveld 408576698