Issue 8351021: Use Closure instead of ScopedRunnableMethodFactory in NetworkMenuButton.

Issue 8351021: Use Closure instead of ScopedRunnableMethodFactory in NetworkMenuButton. (Closed)

Created:
9 years, 2 months ago by achuithb

Modified:
9 years, 2 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use Closure instead of ScopedRunnableMethodFactory in NetworkMenuButton. BUG=chromium-os:22024 TEST=tests pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107080

Patch Set 3 : weak_ptr_factory_ #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	chrome/browser/chromeos/status/network_menu_button.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/chromeos/status/network_menu_button.cc	View	1 2	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

LGTM http://codereview.chromium.org/8351021/diff/2001/chrome/browser/chromeos/status/network_menu_button.h File chrome/browser/chromeos/status/network_menu_button.h (right): http://codereview.chromium.org/8351021/diff/2001/chrome/browser/chromeos/status/network_menu_button.h#newcode163 chrome/browser/chromeos/status/network_menu_button.h:163: base::WeakPtrFactory<NetworkMenuButton> weak_factory_; nit: weak_ptr_factory_ may be a bit ...

9 years, 2 months ago (2011-10-25 01:11:54 UTC) #2

achuithb

9 years, 2 months ago (2011-10-25 08:29:52 UTC) #3

Try server results:
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/56040
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/62827
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...
http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/11326
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/56282
http://build.chromium.org/p/tryserver.chromium/builders/linux_asan/builds/84

http://codereview.chromium.org/8351021/diff/2001/chrome/browser/chromeos/stat...
File chrome/browser/chromeos/status/network_menu_button.h (right):

http://codereview.chromium.org/8351021/diff/2001/chrome/browser/chromeos/stat...
chrome/browser/chromeos/status/network_menu_button.h:163:
base::WeakPtrFactory<NetworkMenuButton> weak_factory_;
On 2011/10/25 01:11:54, satorux1 wrote:
> nit: weak_ptr_factory_ may be a bit more descriptive. 

Done.

Expand Messages | Collapse Messages