Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: content/browser/plugin_service.cc

Issue 8351014: Revert 106962 - Broke plugin_tests - [Linux] Load plugins out-of-process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/plugin_loader_posix_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/plugin_service.cc
===================================================================
--- content/browser/plugin_service.cc (revision 106976)
+++ content/browser/plugin_service.cc (working copy)
@@ -66,7 +66,8 @@
// Callback set on the PluginList to assert that plugin loading happens on the
// correct thread.
void WillLoadPluginsCallback() {
-#if defined(OS_WIN)
+ // TODO(rsesek): Change these to CHECKs.
+#if defined(OS_WIN) || (defined(OS_POSIX) && !defined(OS_MACOSX))
CHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
#else
CHECK(false) << "Plugin loading should happen out-of-process.";
@@ -498,7 +499,7 @@
scoped_refptr<base::MessageLoopProxy> target_loop(
MessageLoop::current()->message_loop_proxy());
-#if defined(OS_WIN)
+#if defined(OS_WIN) || (defined(OS_POSIX) && !defined(OS_MACOSX))
BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
base::Bind(&PluginService::GetPluginsInternal, base::Unretained(this),
target_loop, callback));
« no previous file with comments | « content/browser/plugin_loader_posix_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698