Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: content/browser/plugin_loader_posix.cc

Issue 8351014: Revert 106962 - Broke plugin_tests - [Linux] Load plugins out-of-process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/plugin_loader_posix.h ('k') | content/browser/plugin_loader_posix_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/plugin_loader_posix.cc
===================================================================
--- content/browser/plugin_loader_posix.cc (revision 106976)
+++ content/browser/plugin_loader_posix.cc (working copy)
@@ -45,7 +45,6 @@
canonical_list_.erase(canonical_list_.begin(),
canonical_list_.begin() + next_load_index_ + 1);
next_load_index_ = 0;
-
LoadPluginsInternal();
}
@@ -83,11 +82,6 @@
void PluginLoaderPosix::LoadPluginsInternal() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- // Check if the list is empty or all plugins have already been loaded before
- // forking.
- if (MaybeRunPendingCallbacks())
- return;
-
if (load_start_time_.is_null())
load_start_time_ = base::TimeTicks::Now();
@@ -112,7 +106,7 @@
++next_load_index_;
- MaybeRunPendingCallbacks();
+ RunPendingCallbacks();
}
void PluginLoaderPosix::OnPluginLoadFailed(const FilePath& plugin_path) {
@@ -125,7 +119,7 @@
++next_load_index_;
MaybeAddInternalPlugin(plugin_path);
- MaybeRunPendingCallbacks();
+ RunPendingCallbacks();
}
bool PluginLoaderPosix::MaybeAddInternalPlugin(const FilePath& plugin_path) {
@@ -142,9 +136,9 @@
return false;
}
-bool PluginLoaderPosix::MaybeRunPendingCallbacks() {
+void PluginLoaderPosix::RunPendingCallbacks() {
if (next_load_index_ < canonical_list_.size())
- return false;
+ return;
PluginList::Singleton()->SetPlugins(loaded_plugins_);
for (std::vector<PendingCallback>::iterator it = callbacks_.begin();
@@ -159,8 +153,6 @@
(base::TimeTicks::Now() - load_start_time_)
* base::Time::kMicrosecondsPerMillisecond);
load_start_time_ = base::TimeTicks();
-
- return true;
}
PluginLoaderPosix::PendingCallback::PendingCallback(
« no previous file with comments | « content/browser/plugin_loader_posix.h ('k') | content/browser/plugin_loader_posix_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698