Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8351008: [Mac] Added tooltip support for web intent picker (Closed)

Created:
9 years, 2 months ago by groby-ooo-7-16
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Added tooltip support for web intent picker BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107840

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use iterator instead of indexing vector<> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/web_intent_bubble_controller.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/web_intent_bubble_controller.mm View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
rsesek: Review please? binji: FYI
9 years, 2 months ago (2011-10-24 17:53:38 UTC) #1
Robert Sesek
http://codereview.chromium.org/8351008/diff/1/chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm File chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm (right): http://codereview.chromium.org/8351008/diff/1/chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm#newcode53 chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm:53: for (size_t i = 0; i < urls.size(); ++i) ...
9 years, 2 months ago (2011-10-24 18:00:03 UTC) #2
groby-ooo-7-16
http://codereview.chromium.org/8351008/diff/1/chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm File chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm (right): http://codereview.chromium.org/8351008/diff/1/chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm#newcode53 chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm:53: for (size_t i = 0; i < urls.size(); ++i) ...
9 years, 2 months ago (2011-10-24 21:03:29 UTC) #3
Robert Sesek
lgtm
9 years, 2 months ago (2011-10-24 21:09:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8351008/4002
9 years, 2 months ago (2011-10-24 21:19:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8351008/4002
9 years, 1 month ago (2011-10-28 23:05:57 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-10-29 00:54:55 UTC) #7 
Change committed as 107840

Powered by Google App Engine
This is Rietveld 408576698