Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: chrome/browser/ui/views/status_icons/status_icon_win.cc

Issue 8351004: Add an extra argument to the DisplayBalloon method to support custom notification icons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixing argument order as suggested. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/status_icons/status_icon_win.cc
diff --git a/chrome/browser/ui/views/status_icons/status_icon_win.cc b/chrome/browser/ui/views/status_icons/status_icon_win.cc
index 99b87809f9d772ca9c5c64d65abd68dffe707fb0..9e16e0fdf69a25f4e3b4d6fb598daf0a67195998 100644
--- a/chrome/browser/ui/views/status_icons/status_icon_win.cc
+++ b/chrome/browser/ui/views/status_icons/status_icon_win.cc
@@ -81,8 +81,11 @@ void StatusIconWin::SetToolTip(const string16& tool_tip) {
LOG(WARNING) << "Unable to set tooltip for status tray icon";
}
-void StatusIconWin::DisplayBalloon(const string16& title,
+void StatusIconWin::DisplayBalloon(const SkBitmap& icon,
+ const string16& title,
const string16& contents) {
+ // TODO(leandrogracia): implement custom icons for notification balloons.
Andrew T Wilson (Slow) 2011/10/26 00:38:19 Is there actually anything you can do on windows?
Leandro GraciĆ” Gil 2011/10/26 00:45:11 I have a working code for that and it's provided b
+
NOTIFYICONDATA icon_data;
InitIconData(&icon_data);
icon_data.uFlags = NIF_INFO;
« no previous file with comments | « chrome/browser/ui/views/status_icons/status_icon_win.h ('k') | chrome/browser/ui/views/status_icons/status_tray_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698