Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4586)

Unified Diff: chrome/browser/status_icons/status_icon_unittest.cc

Issue 8351004: Add an extra argument to the DisplayBalloon method to support custom notification icons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixing argument order as suggested. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/status_icons/status_icon_unittest.cc
diff --git a/chrome/browser/status_icons/status_icon_unittest.cc b/chrome/browser/status_icons/status_icon_unittest.cc
index ec41e7ecffd86a29962af0cd409d4802effe2c74..832db095e87a36bac65e1ac90b61e16f78926bca 100644
--- a/chrome/browser/status_icons/status_icon_unittest.cc
+++ b/chrome/browser/status_icons/status_icon_unittest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/compiler_specific.h"
#include "chrome/browser/status_icons/status_icon.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -15,12 +16,13 @@ class MockStatusIconObserver : public StatusIcon::Observer {
class TestStatusIcon : public StatusIcon {
public:
TestStatusIcon() {}
- virtual void SetImage(const SkBitmap& image) {}
- virtual void SetPressedImage(const SkBitmap& image) {}
- virtual void SetToolTip(const string16& tool_tip) {}
- virtual void UpdatePlatformContextMenu(ui::MenuModel* menu) {}
- virtual void DisplayBalloon(const string16& title,
- const string16& contents) {}
+ virtual void SetImage(const SkBitmap& image) OVERRIDE {}
+ virtual void SetPressedImage(const SkBitmap& image) OVERRIDE {}
+ virtual void SetToolTip(const string16& tool_tip) OVERRIDE {}
+ virtual void UpdatePlatformContextMenu(ui::MenuModel* menu) OVERRIDE {}
+ virtual void DisplayBalloon(const SkBitmap& icon,
+ const string16& title,
+ const string16& contents) OVERRIDE {}
};
TEST(StatusIconTest, ObserverAdd) {

Powered by Google App Engine
This is Rietveld 408576698