Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5969)

Unified Diff: chrome/browser/status_icons/status_icon.h

Issue 8351004: Add an extra argument to the DisplayBalloon method to support custom notification icons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixing argument order as suggested. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/status_icons/status_icon.h
diff --git a/chrome/browser/status_icons/status_icon.h b/chrome/browser/status_icons/status_icon.h
index 6bc1347d87580e6cf401e0d1fb621d82f9d02e65..71a350b468dd25c0fdb921a2e1d15fc88af44a83 100644
--- a/chrome/browser/status_icons/status_icon.h
+++ b/chrome/browser/status_icons/status_icon.h
@@ -31,7 +31,9 @@ class StatusIcon {
virtual void SetToolTip(const string16& tool_tip) = 0;
// Displays a notification balloon with the specified contents.
- virtual void DisplayBalloon(const string16& title,
+ // Depending on the platform it might not appear by the icon tray.
+ virtual void DisplayBalloon(const SkBitmap& icon,
+ const string16& title,
const string16& contents) = 0;
// Set the context menu for this icon. The icon takes ownership of the passed
@@ -47,6 +49,8 @@ class StatusIcon {
// (i.e. if there's a context menu set on this status icon, and the user
// right clicks on the icon to display the context menu, OnClicked will not
// be called).
+ // Note: Chrome OS displays the context menu on left button clicks.
+ // This will only be fired for this platform if no context menu is present.
virtual void OnClicked() = 0;
};

Powered by Google App Engine
This is Rietveld 408576698