Issue 8349031: Fixed evaluation order issue in defineProperties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8349031: Fixed evaluation order issue in defineProperties. (Closed)

Created:
9 years, 2 months ago by Sven Panne

Modified:
9 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed evaluation order issue in defineProperties. This is not covered by test262 yet, but it really makes sense and matches Firefox's behaviour. TEST=mjsunit/define-properties.js Committed: http://code.google.com/p/v8/source/detail?r=9694

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
	M	src/v8natives.js	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	M	test/mjsunit/object-define-properties.js	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

9 years, 2 months ago (2011-10-19 09:41:02 UTC) #2

LGTM (with nits).

http://codereview.chromium.org/8349031/diff/1/test/mjsunit/define-properties.js
File test/mjsunit/define-properties.js (right):

http://codereview.chromium.org/8349031/diff/1/test/mjsunit/define-properties....
test/mjsunit/define-properties.js:29: // modifications are done.
Can we add this whole test case to object-define-properties.js instead of adding
a new file?

Expand Messages | Collapse Messages