chrome/browser/ui/webui/options/browser_options_handler.cc - Issue 8349030: Invalid URLs should not be added to startup page list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 8349030: Invalid URLs should not be added to startup page list. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Syncing with codebase. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/browser_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc

index cd57df8b39c8fab3e056cdae1156136aeb1c2a7d..668b3a34f8a58a57b1e61146b30ed458f74db6fb 100644

--- a/chrome/browser/ui/webui/options/browser_options_handler.cc

+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc

@@ -383,6 +383,8 @@ void BrowserOptionsHandler::AddStartupPage(const ListValue* args) {

CHECK(args->GetString(0, &url_string));

GURL url = URLFixerUpper::FixupURL(url_string, std::string());

+ if (!url.is_valid())

+ return;

int index = startup_custom_pages_table_model_->RowCount();

startup_custom_pages_table_model_->Add(index, url);

SaveStartupPagesPref();

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »