Invalid URLs should not be added to startup page list.

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/singleton.h"
@@ skipping 365 matching lines @@
 
   SaveStartupPagesPref();
 }
 
 void BrowserOptionsHandler::AddStartupPage(const ListValue* args) {
   std::string url_string;
   CHECK_EQ(args->GetSize(), 1U);
   CHECK(args->GetString(0, &url_string));
 
   GURL url = URLFixerUpper::FixupURL(url_string, std::string());
+  // Invalid urls should not be added to the list. http://crbug.com/100658.
+  if (url.spec().empty())

[csilv, 2011/10/19 18:49:48]

I think url.is_valid() would be a better choice here.  I also think the comment
is unnecessary, adding the is_valid() check will be self documenting.

[rosen.dash, 2011/10/20 06:31:25]

Done.

+    return;
   int index = startup_custom_pages_table_model_->RowCount();
   startup_custom_pages_table_model_->Add(index, url);
   SaveStartupPagesPref();
 }
 
 void BrowserOptionsHandler::EditStartupPage(const ListValue* args) {
   std::string url_string;
   std::string index_string;
   int index;
   CHECK_EQ(args->GetSize(), 2U);
@@ skipping 84 matching lines @@
     DictionaryValue* entry = new DictionaryValue();
     entry->SetString("title", match.description);
     entry->SetString("displayURL", match.contents);
     entry->SetString("url", match.destination_url.spec());
     suggestions.Append(entry);
   }
 
   web_ui_->CallJavascriptFunction(
       "BrowserOptions.updateAutocompleteSuggestions", suggestions);
 }