Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: src/mips/ic-mips.cc

Issue 8348028: MIPS: port Fix evaluation order of GT and LTE operators. (Closed)
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1542 matching lines...) Expand 10 before | Expand all | Expand 10 after
1553 1553
1554 1554
1555 Condition CompareIC::ComputeCondition(Token::Value op) { 1555 Condition CompareIC::ComputeCondition(Token::Value op) {
1556 switch (op) { 1556 switch (op) {
1557 case Token::EQ_STRICT: 1557 case Token::EQ_STRICT:
1558 case Token::EQ: 1558 case Token::EQ:
1559 return eq; 1559 return eq;
1560 case Token::LT: 1560 case Token::LT:
1561 return lt; 1561 return lt;
1562 case Token::GT: 1562 case Token::GT:
1563 // Reverse left and right operands to obtain ECMA-262 conversion order. 1563 return gt;
1564 return lt;
1565 case Token::LTE: 1564 case Token::LTE:
1566 // Reverse left and right operands to obtain ECMA-262 conversion order. 1565 return le;
1567 return ge;
1568 case Token::GTE: 1566 case Token::GTE:
1569 return ge; 1567 return ge;
1570 default: 1568 default:
1571 UNREACHABLE(); 1569 UNREACHABLE();
1572 return kNoCondition; 1570 return kNoCondition;
1573 } 1571 }
1574 } 1572 }
1575 1573
1576 1574
1577 void CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) { 1575 void CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) {
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
1666 Register reg = Register::from_code(Assembler::GetRs(instr_at_patch)); 1664 Register reg = Register::from_code(Assembler::GetRs(instr_at_patch));
1667 patcher.masm()->andi(at, reg, kSmiTagMask); 1665 patcher.masm()->andi(at, reg, kSmiTagMask);
1668 patcher.ChangeBranchCondition(eq); 1666 patcher.ChangeBranchCondition(eq);
1669 } 1667 }
1670 } 1668 }
1671 1669
1672 1670
1673 } } // namespace v8::internal 1671 } } // namespace v8::internal
1674 1672
1675 #endif // V8_TARGET_ARCH_MIPS 1673 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698