Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 8348003: add support for using system jpeg headers here for OpenBSD (Closed)

Created:
9 years, 2 months ago by Robert Nagy
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

add support for using system jpeg headers here for OpenBSD BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106127

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment on local change and security section #

Total comments: 2

Patch Set 3 : better comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M third_party/iccjpeg/README.chromium View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/iccjpeg/iccjpeg.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/iccjpeg/iccjpeg.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Robert Nagy
Please review the following OpenBSD patches. Thanks
9 years, 2 months ago (2011-10-18 18:00:29 UTC) #1
Mark Mentovai
http://codereview.chromium.org/8348003/diff/1/third_party/iccjpeg/iccjpeg.h File third_party/iccjpeg/iccjpeg.h (right): http://codereview.chromium.org/8348003/diff/1/third_party/iccjpeg/iccjpeg.h#newcode21 third_party/iccjpeg/iccjpeg.h:21: #if defined(USE_SYSTEM_LIBJPEG) You need to edit README.chromium if you ...
9 years, 2 months ago (2011-10-18 18:10:57 UTC) #2
Robert Nagy
http://codereview.chromium.org/8348003/diff/1/third_party/iccjpeg/iccjpeg.h File third_party/iccjpeg/iccjpeg.h (right): http://codereview.chromium.org/8348003/diff/1/third_party/iccjpeg/iccjpeg.h#newcode21 third_party/iccjpeg/iccjpeg.h:21: #if defined(USE_SYSTEM_LIBJPEG) On 2011/10/18 18:10:58, Mark Mentovai wrote: > ...
9 years, 2 months ago (2011-10-18 18:27:12 UTC) #3
Robert Nagy
On 2011/10/18 18:27:12, Robert Nagy wrote: > http://codereview.chromium.org/8348003/diff/1/third_party/iccjpeg/iccjpeg.h > File third_party/iccjpeg/iccjpeg.h (right): > > http://codereview.chromium.org/8348003/diff/1/third_party/iccjpeg/iccjpeg.h#newcode21 ...
9 years, 2 months ago (2011-10-18 18:27:48 UTC) #4
Mark Mentovai
http://codereview.chromium.org/8348003/diff/1003/third_party/iccjpeg/README.chromium File third_party/iccjpeg/README.chromium (right): http://codereview.chromium.org/8348003/diff/1003/third_party/iccjpeg/README.chromium#newcode17 third_party/iccjpeg/README.chromium:17: the system, so a USE_SYSTEM_LIBJPEG ifdef is added to ...
9 years, 2 months ago (2011-10-18 18:29:39 UTC) #5
Robert Nagy
http://codereview.chromium.org/8348003/diff/1003/third_party/iccjpeg/README.chromium File third_party/iccjpeg/README.chromium (right): http://codereview.chromium.org/8348003/diff/1003/third_party/iccjpeg/README.chromium#newcode17 third_party/iccjpeg/README.chromium:17: the system, so a USE_SYSTEM_LIBJPEG ifdef is added to ...
9 years, 2 months ago (2011-10-18 18:32:22 UTC) #6
Mark Mentovai
LGTM
9 years, 2 months ago (2011-10-18 18:33:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8348003/6001
9 years, 2 months ago (2011-10-18 18:34:13 UTC) #8
commit-bot: I haz the power
9 years, 2 months ago (2011-10-18 20:57:39 UTC) #9
Change committed as 106127

Powered by Google App Engine
This is Rietveld 408576698