Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 8347032: Fix from Paul Lind that helps post-isolates V8 work with older (Closed)

Created:
9 years, 2 months ago by Erik Corry
Modified:
9 years, 2 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Fix from Paul Lind that helps post-isolates V8 work with older Android releases. See http://code.google.com/p/v8/issues/detail?id=1780 Committed: http://code.google.com/p/v8/source/detail?r=9689

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/api.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
9 years, 2 months ago (2011-10-19 07:26:20 UTC) #1
Rico
LGTM with fix http://codereview.chromium.org/8347032/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/8347032/diff/1/src/api.cc#newcode4008 src/api.cc:4008: if (!isolate || !i::Isolate::Current()->IsInitialized()) return true; ...
9 years, 2 months ago (2011-10-19 07:45:18 UTC) #2
Rico
LGTM
9 years, 2 months ago (2011-10-19 07:48:27 UTC) #3
Rico
9 years, 2 months ago (2011-10-19 07:48:28 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698