Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8733)

Unified Diff: chrome/browser/automation/testing_automation_provider_chromeos.cc

Issue 8347016: chromeos: Simplify power supply info in PowerLibrary (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: support unit testing, added power supply status struct Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/testing_automation_provider_chromeos.cc
diff --git a/chrome/browser/automation/testing_automation_provider_chromeos.cc b/chrome/browser/automation/testing_automation_provider_chromeos.cc
index 66a3d91d891e4be73fb32abe5f30533d26b840ad..8680977773db1c39d87e584915cdb054b5eb154b 100644
--- a/chrome/browser/automation/testing_automation_provider_chromeos.cc
+++ b/chrome/browser/automation/testing_automation_provider_chromeos.cc
@@ -210,6 +210,11 @@ DictionaryValue* CreateDictionaryWithPolicies(
} // namespace
+void TestingAutomationProvider::PowerChanged(
+ const chromeos::PowerSupplyStatus& status) {
+ power_status_ = status;
+}
+
void TestingAutomationProvider::GetLoginInfo(DictionaryValue* args,
IPC::Message* reply_message) {
AutomationJSONReply reply(this, reply_message);
@@ -342,23 +347,22 @@ void TestingAutomationProvider::GetBatteryInfo(DictionaryValue* args,
if (!EnsureCrosLibraryLoaded(this, reply_message))
return;
- chromeos::PowerLibrary* power_library = CrosLibrary::Get()->GetPowerLibrary();
scoped_ptr<DictionaryValue> return_value(new DictionaryValue);
return_value->SetBoolean("battery_is_present",
- power_library->IsBatteryPresent());
- return_value->SetBoolean("line_power_on", power_library->IsLinePowerOn());
- if (power_library->IsBatteryPresent()) {
+ power_status_.battery_is_present);
+ return_value->SetBoolean("line_power_on", power_status_.line_power_on);
+ if (power_status_.battery_is_present) {
return_value->SetBoolean("battery_fully_charged",
- power_library->IsBatteryFullyCharged());
+ power_status_.battery_is_full);
return_value->SetDouble("battery_percentage",
- power_library->GetBatteryPercentage());
- if (power_library->IsLinePowerOn()) {
- int time = power_library->GetBatteryTimeToFull().InSeconds();
- if (time > 0 || power_library->IsBatteryFullyCharged())
+ power_status_.battery_percentage);
+ if (power_status_.line_power_on) {
+ int64 time = power_status_.battery_time_to_full;
+ if (time > 0 || power_status_.battery_is_full)
return_value->SetInteger("battery_time_to_full", time);
} else {
- int time = power_library->GetBatteryTimeToEmpty().InSeconds();
+ int64 time = power_status_.battery_time_to_empty;
if (time > 0)
return_value->SetInteger("battery_time_to_empty", time);
}

Powered by Google App Engine
This is Rietveld 408576698