Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2846)

Unified Diff: chrome/browser/chromeos/status/power_menu_button.cc

Issue 8347016: chromeos: Simplify power supply info in PowerLibrary (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Various comment fixes Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/status/power_menu_button.cc
diff --git a/chrome/browser/chromeos/status/power_menu_button.cc b/chrome/browser/chromeos/status/power_menu_button.cc
index efd4ee157351f71c628d028232e3b2448a36dda5..468adfd7852cfc358cfa945be45fafb55d0f9560 100644
--- a/chrome/browser/chromeos/status/power_menu_button.cc
+++ b/chrome/browser/chromeos/status/power_menu_button.cc
@@ -350,7 +350,8 @@ void PowerMenuButton::RunMenu(views::View* source, const gfx::Point& pt) {
////////////////////////////////////////////////////////////////////////////////
// PowerMenuButton, PowerLibrary::Observer implementation:
-void PowerMenuButton::PowerChanged(PowerLibrary* obj) {
+void PowerMenuButton::PowerChanged(const PowerSupplyStatus& power_status) {
+ power_status_ = power_status;
UpdateIconAndLabelInfo();
}
@@ -358,23 +359,21 @@ void PowerMenuButton::PowerChanged(PowerLibrary* obj) {
// PowerMenuButton, StatusAreaButton implementation:
void PowerMenuButton::UpdateIconAndLabelInfo() {
- PowerLibrary* power_lib = CrosLibrary::Get()->GetPowerLibrary();
-
- battery_is_present_ = power_lib->IsBatteryPresent();
- line_power_on_ = power_lib->IsLinePowerOn();
+ battery_is_present_ = power_status_.battery_is_present;
+ line_power_on_ = power_status_.line_power_on;
// If fully charged, always show 100% even if internal number is a bit less.
- if (power_lib->IsBatteryFullyCharged()) {
- // We always call power_lib->GetBatteryPercentage() for test predictability.
- power_lib->GetBatteryPercentage();
+ if (power_status_.battery_is_full)
battery_percentage_ = 100.0;
- } else {
- battery_percentage_ = power_lib->GetBatteryPercentage();
- }
+ else
+ battery_percentage_ = power_status_.battery_percentage;
- UpdateBatteryTime(&battery_time_to_full_, power_lib->GetBatteryTimeToFull());
+ UpdateBatteryTime(&battery_time_to_full_,
+ TimeDelta::FromSeconds(
+ power_status_.battery_seconds_to_full));
UpdateBatteryTime(&battery_time_to_empty_,
- power_lib->GetBatteryTimeToEmpty());
+ TimeDelta::FromSeconds(
+ power_status_.battery_seconds_to_empty));
string16 tooltip_text;
if (!battery_is_present_) {
« no previous file with comments | « chrome/browser/chromeos/status/power_menu_button.h ('k') | chrome/browser/chromeos/status/power_menu_button_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698